milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: use different value to get related data size according to segment type

Open SimFG opened this issue 1 year ago • 6 comments

issue: #30436

SimFG avatar May 13 '24 09:05 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 10:05 mergify[bot]

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 13 '24 10:05 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 11:05 mergify[bot]

/approve /lgtm

czs007 avatar May 13 '24 13:05 czs007

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 14:05 mergify[bot]

/run-cpu-e2e

czs007 avatar May 14 '24 01:05 czs007

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 14 '24 02:05 mergify[bot]

/run-cpu-e2e

SimFG avatar May 14 '24 02:05 SimFG

/run-cpu-e2e

SimFG avatar May 14 '24 03:05 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 14 '24 03:05 mergify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 14 '24 03:05 sre-ci-robot

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.08%. Comparing base (293f14a) to head (0e3d0f5). Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33017      +/-   ##
==========================================
+ Coverage   82.06%   82.08%   +0.01%     
==========================================
  Files        1007     1005       -2     
  Lines      127699   127649      -50     
==========================================
- Hits       104793   104776      -17     
+ Misses      18931    18887      -44     
- Partials     3975     3986      +11     
Files Coverage Δ
internal/querycoordv2/utils/types.go 78.94% <ø> (-6.24%) :arrow_down:
internal/querynodev2/segments/retrieve.go 78.44% <100.00%> (ø)
internal/querynodev2/segments/utils.go 39.37% <100.00%> (+10.01%) :arrow_up:
internal/querynodev2/tasks/query_task.go 91.66% <100.00%> (ø)
internal/querynodev2/tasks/search_task.go 82.86% <70.00%> (-0.43%) :arrow_down:

... and 52 files with indirect coverage changes

codecov[bot] avatar May 14 '24 05:05 codecov[bot]

/lgtm

jaime0815 avatar May 14 '24 06:05 jaime0815