rethinkdb-websocket-server icon indicating copy to clipboard operation
rethinkdb-websocket-server copied to clipboard

Published 20 hours ago • verified publisher icon mikemintz

Support websocket compression

Open casprack opened this issue 7 years ago • 2 comments

In index.js, perMessageDeflate is set to false (here). There's a accompanying comment indicating that this was because of a bug in websockets (here). This bug has been fixed and it would be great if compression was supported in this package, potentially even by default.

I did some testing in my environment and everything seems to work perfectly when compression is enabled, and delivers significant reductions in network traffic.

casprack avatar Apr 26 '18 17:04 casprack

Good find! Would you mind submitting a PR enabling compression by default, and I can go ahead and bump a new version.

mikemintz avatar Apr 28 '18 02:04 mikemintz

Created a pull request. Can you go ahead and merge it?

shareefalis avatar Apr 07 '20 16:04 shareefalis