Mike Brown

there may be a hole.. in the kubeadm upgrade process when moving from docker to containerd. Docker's image cache is different from containerd's image cache. Make sure to link your...

My bad I read the above as it's working fine in crictl with your config.toml, I missed that the formatting of your config.toml was off. See: https://github.com/containerd/containerd/blob/master/docs/cri/registry.md#configure-registry-credentials

> @mikebrow Thanks a bunch for linking me to the official documentation, using it I was able to solve my problem. Your welcome, glad to help. > I'm guessing the...

deja-vu :-) https://github.com/containerd/cri/pull/281#discussion_r140793069 .. was done this way because of the way it was originally implemented in dockershim. I also prefer the Alternative "consistent" Behavior. Would require a KEP, I...

same with the enum.. I like it.. and that would need to be done through a KEP before we could change CRI defaults. If you like we could work together...

.cc @BenTheElder @Random-Liu @fuweid

> Thanks for the patch. > > Test it in my local and give the comment. > > > Just not a fan to update the watcher during loop. Maybe...

/ok-to-test

@ruiwen-zhao looking good just some cleanup now I think..

good catch on the sync to store of status now that it holds spec updates, otherwise on restart... yes pls, on opening a new issue for windows cri for the...