material-ui-color icon indicating copy to clipboard operation
material-ui-color copied to clipboard

Can you publish a package that supports @mui v5 ?

Open cyulin opened this issue 4 years ago • 16 comments

material-ui-color is a very good project and I want to continue using it.

But the latest version of the package(v1.2.0) still uses @material-ui/core v4. I use @mui/material v5 in my project, and I found that @material-ui/core and @mui/material have style conflicts.

thank you very much!

cyulin avatar Oct 27 '21 03:10 cyulin

I'm looking for this package to support MUI V5.

ramanjaneya-karnati avatar Oct 29 '21 01:10 ramanjaneya-karnati

yes please! :)

thanks for the great package...

hiaselhans avatar Nov 01 '21 19:11 hiaselhans

Looks like this is already fixed in the master branch: https://github.com/mikbry/material-ui-color/pull/178 But likely needs further testing and a tagged release. @mikbry is it possible to get a tagged release for V5 support?

roborew avatar Nov 08 '21 17:11 roborew

I'm sorry, I accidentally made a Mention. I'm looking forward to the release :)

ValetCona avatar Nov 23 '21 16:11 ValetCona

Hi, Any update on the support release for mui v5?

Thanks in advance.

ThabrezAhmed avatar Nov 30 '21 06:11 ThabrezAhmed

Sorry for the lack of update on migration to mui v5, but I need futher tests as it completely breaks compatibility with v4. Actual master branch isn't passing tests so I am not ok with that.

mikbry avatar Dec 05 '21 18:12 mikbry

I just released mui-color 2.0.0-beta.1 which will be the port of Material-ui-color to Mui v5. There are several bugs, need to update the doc, I will fix them or if you want you could make a PR.

mikbry avatar Dec 05 '21 19:12 mikbry

I will also revert all v5 changes in this repo, so I could fix new issues in material-ui-color

mikbry avatar Dec 05 '21 19:12 mikbry

Hi @mikbry, Any updates on release

ThabrezAhmed avatar Dec 30 '21 17:12 ThabrezAhmed

@ThabrezAhmed For Mui v5 I created a new package mui-color : https://github.com/mikbry/mui-color . It is an alpha, design need to be enhanced.

mikbry avatar Jan 03 '22 07:01 mikbry

Hi, thank you for the package :) I just changed to MUI5, and trying this out, but I'm getting an error because it's trying to use @mui/styles, which should be removed if using MUI5 (or to be used only temporarily)

./node_modules/mui-color/esm/index.js:1:278
Module not found: Can't resolve '@mui/styles'

solshuffle avatar Jan 03 '22 13:01 solshuffle

I had to include the following in my webpack config (I am using nextjs with it)

// resolves material-ui-colors breaking the app
		config.resolve.alias[ '@material-ui/core/Box' ] = path.resolve( basePath, './node_modules/@mui/material/Box' );
		config.resolve.alias[ '@material-ui/core/Button' ] = path.resolve( basePath, './node_modules/@mui/material/Button' );
		config.resolve.alias[ '@material-ui/core/Divider' ] = path.resolve( basePath, './node_modules/@mui/material/Divider' );
		config.resolve.alias[ '@material-ui/core/FormControl' ] = path.resolve( basePath, './node_modules/@mui/material/FormControl' );
		config.resolve.alias[ '@material-ui/core/FormHelperText' ] = path.resolve( basePath, './node_modules/@mui/material/FormHelperText' );
		config.resolve.alias[ '@material-ui/core/Input' ] = path.resolve( basePath, './node_modules/@mui/material/Input' );
		config.resolve.alias[ '@material-ui/core/InputAdornment' ] = path.resolve( basePath, './node_modules/@mui/material/InputAdornment' );
		config.resolve.alias[ '@material-ui/core/InputLabel' ] = path.resolve( basePath, './node_modules/@mui/material/InputLabel' );
		config.resolve.alias[ '@material-ui/core/Popover' ] = path.resolve( basePath, './node_modules/@mui/material/Popover' );
		config.resolve.alias[ '@material-ui/core/Slider' ] = path.resolve( basePath, './node_modules/@mui/material/Slider' );
		config.resolve.alias[ '@material-ui/core/styles' ] = path.resolve( basePath, './node_modules/@mui/styles' );
		config.resolve.alias[ '@material-ui/core/TextField' ] = path.resolve( basePath, './node_modules/@mui/material/TextField' );
		config.resolve.alias[ '@material-ui/core/Tooltip' ] = path.resolve( basePath, './node_modules/@mui/material/Tooltip' );

where basePath is sent for relative path for my other repos that call my library repo, which is where this config lives

rafde avatar Jan 24 '22 20:01 rafde

Hey, thanks for the great package and the alpha. The alpha seems almost fully operational ! 😃

JeanFabry avatar Apr 29 '22 09:04 JeanFabry

i have published a fixed version of this package that works with latest mui5: https://www.npmjs.com/package/material5-ui-color out of the box

cykoder avatar Aug 25 '22 18:08 cykoder

This package (https://viclafouch.github.io/mui-color-input/) handles this problem, supports both React 17 / 18 and MUI V5

viclafouch avatar Aug 29 '22 10:08 viclafouch

I will update Mui-color support based on new Mui and react 17/ 18 , https://github.com/mikbry/mui-color

mikbry avatar Aug 29 '22 10:08 mikbry