editly icon indicating copy to clipboard operation
editly copied to clipboard

Include ffmpeg

Open mifi opened this issue 5 years ago • 11 comments

Might add the ffmpeg-static dependency, then no need for system ffmpeg. (with an option to use a custom ffmpeg path) But it does not work on raspberry pi, need to see if it crashes npm install or what happens

mifi avatar Apr 28 '20 17:04 mifi

looks like ffprobe is separate

https://github.com/eugeneware/ffmpeg-static/issues/19

??

https://github.com/joshwnj/ffprobe-static

chapmanjacobd avatar Apr 28 '20 17:04 chapmanjacobd

Yeah, I'm thinking about building a reusable ffmpeg GitHub Action and a repository that can build ffmpeg for many platforms in many different variants and allow users to fork the repo for their own build configuration, but it's kind of a big job.

mifi avatar May 03 '20 09:05 mifi

looks like someone has done something similar before:

https://github.com/vot/ffbinaries-api https://github.com/vot/ffbinaries-node

chapmanjacobd avatar May 03 '20 10:05 chapmanjacobd

I found that one too, but there seems to be some issues with those builds not really being static builds. I haven't tried them myself and I'm not sure where he gets the builds from, but I think that the official builds from ffmpeg.org are preferred because they are well tested by a lot of people. And it seems kind of abandoned, also it doesn't have the latest 4.2.2 version: https://github.com/vot/ffbinaries-prebuilt/releases

mifi avatar May 03 '20 15:05 mifi

oh... for some reason I thought this repo https://github.com/vot/ffbinaries-api included the code for automatically compiling from nightly builds or something :/

chapmanjacobd avatar May 03 '20 18:05 chapmanjacobd

no. it just contains references to downloads from the other repo. So the question is, how are the ffmpeg-prebuilt being built. I've created an issue for that

mifi avatar May 04 '20 09:05 mifi

@mifi since You're discussing FFMPEG builds we're using these: https://johnvansickle.com/ffmpeg/ And they're always bringing a warning to console because editly complains on 'Unknown version string' It's because they don't have same build string as official FFMPEG builds (e.g. ffmpeg version N-50742-ga7245adee3-static https://johnvansickle.com/ffmpeg/.... Can You please take a look on these?

maksym-plotnikov avatar Nov 27 '20 08:11 maksym-plotnikov

Ohh. Are you using "release: 4.3.1"? or "git master" ?

mifi avatar Dec 08 '20 18:12 mifi

Please try 4.3.1 and see if you get the same error

mifi avatar Dec 08 '20 18:12 mifi

FFMPeg binaries on windows don't have the same version string. I am getting this - N-101088-g6f80953554

cyrilgupta avatar Feb 15 '21 05:02 cyrilgupta

where did you download ffmpeg from?

mifi avatar Feb 15 '21 19:02 mifi