midway icon indicating copy to clipboard operation
midway copied to clipboard

Published 20 hours ago β€’ verified publisher icon midwayjs

feat(core): change type of dataSourceName from string to PropertyKey(string, number, symbol)

Open waitingsong opened this issue 3 years ago β€’ 2 comments

waitingsong avatar Jul 31 '22 14:07 waitingsong

gitpod-io[bot] avatar Jul 31 '22 14:07 gitpod-io[bot]

Codecov Report

Merging #2184 (34b20a0) into main (3668748) will decrease coverage by 0.12%. The diff coverage is 100.00%.

:exclamation: Current head 34b20a0 differs from pull request most recent head 9943a2d. Consider uploading reports for the commit 9943a2d to get more accurate results

@@            Coverage Diff             @@
##             main    #2184      +/-   ##
==========================================
- Coverage   82.08%   81.96%   -0.13%     
==========================================
  Files         433      433              
  Lines       15190    15190              
  Branches     3590     3590              
==========================================
- Hits        12469    12450      -19     
- Misses       2487     2503      +16     
- Partials      234      237       +3
Impacted Files Coverage Ξ”
packages/core/src/common/dataSourceManager.ts 100.00% <100.00%> (ΓΈ)
packages/oss/src/manager.ts 38.88% <0.00%> (-50.00%) :arrow_down:
packages/oss/src/configuration.ts 60.00% <0.00%> (-40.00%) :arrow_down:
packages/upload/src/parse.ts 93.70% <0.00%> (+0.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 3668748...9943a2d. Read the comment docs.

codecov-commenter avatar Jul 31 '22 15:07 codecov-commenter