vscode-remote-release icon indicating copy to clipboard operation
vscode-remote-release copied to clipboard

"Using localhost in Docker Compose" doc can have some improvement

Open doggy8088 opened this issue 3 years ago • 0 comments

I think this doc can be improved for forwardPorts description.

Here is the issue I found.

  1. I have a ASP.NET Core 6 app with a MS SQL Server database.

  2. Add .devcontainer files to the project.

    I choose C# (.NET) and MS SQL.

  3. The .devcontainer/docker-compose.yml file have the following comment.

    db:
      image: mcr.microsoft.com/mssql/server:2019-latest
      restart: unless-stopped
      environment:
        SA_PASSWORD: P@ssw0rd
        ACCEPT_EULA: Y
      # Add "forwardPorts": ["1433"] to **devcontainer.json** to forward MSSQL locally.
      # (Adding the "ports" property to this file will not forward from a Codespace.)
    

The Add "forwardPorts": ["1433"] to **devcontainer.json** to forward MSSQL locally. is misleading and this doc doesn't provide any details. The correct description should be Add "forwardPorts": ["db:1433"] to **devcontainer.json**.

I do find more details here. The devcontainer.json reference is really helpful. If the doc can provide a link, that will be awesome. 👍

I don't know where is the right place to create this issue. If I am creating the wrong place, please let me know. Thanks.

doggy8088 avatar Aug 07 '22 13:08 doggy8088