vscode-remote-release icon indicating copy to clipboard operation
vscode-remote-release copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Using `code` command to open new tab opens more than 1 tabs at once

Open karuboniru opened this issue 3 years ago • 1 comments

  • VSCode Version: 1.69.1
  • Local OS Version: Windows 11 FireFox 102.0.1
  • Remote OS Version:
  • Remote Extension/Connection Type: Server
  • Logs:

Steps to Reproduce:

  1. Setup code-server, serve-local and open multiple instances in browser tabs
  2. In any of them, open terminal in code, run code /any/path
  3. Multiple browser tabs are opened, as many as currently opened code browser tabs.

karuboniru avatar Jul 14 '22 15:07 karuboniru

Thanks for the issue, I can readily reproduce this. It also doesn't happen in remote SSH.

I would guess for desktop we just get deduplication for free since, when each window tries to open the folder URI, the main process just focuses the existing window for each additional request. However, in the web this doesn't happen. I think the way to fix this would be to either introduce some kind of deduplication in the remote extension host CLI server, or having some small "lock" in session storage on the vscode.dev side to prevent tabs from opening the duplicate windows. The latter is probably easier since I'm not sure there's a way to say "this command should be delivered only once."

@alexdima is this accurate / do you have any other recommendations?

connor4312 avatar Aug 05 '22 20:08 connor4312

This was fixed in https://github.com/microsoft/vscode/commit/677b083284ed89d2d237c583dbb6a3d6a8edc2e4

connor4312 avatar Sep 15 '22 22:09 connor4312