typescript-tslint-plugin icon indicating copy to clipboard operation
typescript-tslint-plugin copied to clipboard

alwaysShowRuleFailuresAsWarnings doesn't change severity

Open Ky6uk opened this issue 6 years ago • 6 comments

I'm trying to migrate to this plugin from deprecated vscode-tslint. My configuration is

{
  "extends": "./tsconfig.base",

  "plugins": [{
    "name": "typescript-tslint-plugin",
    "alwaysShowRuleFailuresAsWarnings": false
  }]
}

But alwaysShowRuleFailuresAsWarnings has no effect and errors are always displaying as warnings. vscode-tslint works fine.

VSCode v1.30.0 TypeScript v3.1.6 (workspace) and v3.2.2 (vscode)

Ky6uk avatar Dec 13 '18 12:12 Ky6uk

I'm having the same issue

WhiteAbeLincoln avatar Dec 13 '18 20:12 WhiteAbeLincoln

Did you configure the tslint.json to have default level of warning?

mjbvz avatar Dec 13 '18 20:12 mjbvz

Nope. I also have severity "error" for rule I see as warning.

Ky6uk avatar Dec 14 '18 08:12 Ky6uk

We're experiencing the same issue. When we run lint via the CLI, we get errors/warnings as configured. In VS code they all appear as warnings. However, if I re-save the tsconfig file (even with no modifications), then after 15-20 seconds the plugin appears to honor the setting (the green squiggles change to red for errors). It seems like the plugin is listening for tsconfig changes and applying the setting, but sadly doesn't appear to apply them correctly on initial load.

A side question, why is alwaysShowRuleFailuresAsWarnings defaulted to true?

craigsmitham avatar Jan 22 '19 18:01 craigsmitham

I also found a strange behavior at v0.3.1. First time VSCode ignores alwaysShowRuleFailuresAsWarnings: true and displays errors as warnings. But when I tried to re-save tsconfig.json file with no changes the warnings magically turned to errors.

Ky6uk avatar Apr 16 '19 08:04 Ky6uk

I'm encountering the same problem as what @craigsmitham describes

jcyuan avatar Apr 26 '19 03:04 jcyuan

Closing as TSLint has been deprecated in favor of ESLint. We are archiving this repo as this project is no longer maintained

mjbvz avatar May 01 '23 20:05 mjbvz