terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Fix the bad default light theme selection background color

Open uoRetr0 opened this issue 1 year ago • 2 comments

Summary of the Pull Request

Fixed default selection background colors with light schemes. Default color now matches the scheme and contrasts well

References and Relevant Issues

none

Detailed Description of the Pull Request / Additional comments

This is my first contribution ever :) Even though its simple, im happy to help

Validation Steps Performed

PR Checklist

  • [ ] Closes #8716
  • [ ] Tests added/passed
  • [ ] Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • [ ] Schema updated (if necessary)

uoRetr0 avatar Feb 29 '24 22:02 uoRetr0

You submitted this pull request at just the right time! We finally fixed a long-standing issue where changes to the default color schemes would be ignored for existing users. Thanks!

We'll get this reviewed ASAP

DHowett avatar Feb 29 '24 22:02 DHowett

OneHalf light: image

Solarized: image

Tango: image

zadjii-msft avatar Apr 26 '24 11:04 zadjii-msft