terminal
terminal copied to clipboard
microsoft
profile-icons with web sources are not shown on the taskbar
Windows Terminal version (or Windows build number)
1.8.1521.0
Other Software
No response
Steps to reproduce
I am using WINDOWS 11, I do not know how this behaves in Win10.
- Create a new profile (or use an existing one)
- For the icon, paste a weblink to an ico file (eg https://github.com/favicon.ico)
- As you will see, that works fine (the icon gets shown in new tabs and in the settings menu)
- keep winterm open
- right-click onto the program in the taskbar
- As you will see, the icons are not rendered here
Expected Behavior
Profile Icons are rendered the same way everywhere across the device
Actual Behavior
Profile Icons from the web are not rendered at all in the taskbar dialog
You know, I am confident that we have a dupe for this floating around on the repo, but I can't find it. The same thing happens when using an emoji as the icon for a profile.
I suppose theoretically, we could actually download the image locally and set the path for the jumplist entry to that file.
I suppose theoretically, we could actually download the image locally and set the path for the jumplist entry to that file.
I someone is going to implement that, maybe also make copies of local images to an app-internal path. I found it somewhat annoying that I have to make sure that my custom local icons do not get deleted by accident.
Like for example when I download an image, set it as profile icon, and then clean up my downloads folder, the profile icon is gone.
Yeah -- we should cache local and remote paths, honestly. We need to be extra careful to not cache old copies of local icons that have changed, but that should present little issue.
Technically -- and unrelatedly, mind you -- we should also be caching them in memory. Reloading every image every time the settings changes is a right pain. :smile:
Hello @torgeros, is this issue is still open, I like to work on this issue. I am new to open source and want to contribute.
I am not planning on working on this myself. No one else has posted something about them working on it.
Feel free to fork the repo and then open a pull request referencing this issue.
I've noticed this too - shows up fine within Terminal but not in the jump menu for my WSL instance...
This is still an issue
@JavierCCC try to re-pin it or reinstall.
didnt work
Soon, profile icons with web sources will not be shown at all. It's a trivial security risk.
Soon, profile icons with web sources will not be shown at all. It's a trivial security risk.
Is that related to something with wsl --install, --import, or --export? Because it can't figure out the correct directory for shortcut.ico. Since version 2.4.x, I have to manually set the path for the profile icon of the distro that came from a WSL install.
Jesus Christ Windows Terminal....
