pxt icon indicating copy to clipboard operation
pxt copied to clipboard

Auto-layout of blocks should position the start block at the top-left.

Open matthewtebbs opened this issue 7 years ago • 6 comments

The code actually checks for whether the start block is at top-left and if other blocks are not to decide if it should re-layout.

I suspect the current code will auto-layout my hand-positioned blocks if start is not top-left which is not expected.

matthewtebbs avatar Apr 22 '18 21:04 matthewtebbs

Creating PR for this bug-fix.

matthewtebbs avatar Apr 23 '18 14:04 matthewtebbs

Sweet.


From: Sam El-Husseini [email protected] Sent: Monday, April 23, 2018 8:24:26 AM To: Microsoft/pxt Cc: Matthew Tebbs; Assign Subject: Re: [Microsoft/pxt] Auto-layout of blocks should position the start block at the top-left. (#4194)

Assigned #4194https://github.com/Microsoft/pxt/issues/4194 to @matthewtebbshttps://github.com/matthewtebbs.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/pxt/issues/4194#event-1589444243, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABW9h-wN1bAkNUjVwjsnIZ6wHPzAi4cYks5trfIqgaJpZM4TfCDg.

matthewtebbs avatar Apr 23 '18 15:04 matthewtebbs

Why was this closed?


From: Abhijith Chatra [email protected] Sent: Tuesday, May 15, 2018 4:43:47 PM To: Microsoft/pxt Cc: Matthew Tebbs; Mention Subject: Re: [Microsoft/pxt] Auto-layout of blocks should position the start block at the top-left. (#4194)

Closed #4194https://github.com/Microsoft/pxt/issues/4194.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/pxt/issues/4194#event-1628439015, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABW9h1896tqwG5pMG-wdwVAL98-QtDJZks5ty2gzgaJpZM4TfCDg.

matthewtebbs avatar May 16 '18 01:05 matthewtebbs

I assumed you made the pr as per comments. Reopening

abchatra avatar May 16 '18 01:05 abchatra

Hi! I have a project for a software methodology class to contribute to an open source repo and I am very interested in this project. Could I be assigned to this issue?

jlbrewe avatar Feb 02 '21 14:02 jlbrewe

@jlbrewe feel free to pick this up. Make sure this issue still reproduces.

abchatra avatar Feb 03 '21 17:02 abchatra