live-share

live-share copied to clipboard

• Issue Type: Bug
• Extension Name: vsliveshare
• Extension Version: 1.0.3206
• OS Version: Windows_NT x64 10.0.19041
• VSCode version: 1.51.1

{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 197,
		"activateCallTime": 2,
		"activateResolvedTime": 10832,
		"activationReason": {
			"startup": true,
			"extensionId": {
				"value": "ms-vsliveshare.vsliveshare",
				"_lower": "ms-vsliveshare.vsliveshare"
			},
			"activationEvent": "*"
		}
	},
	"runtimeErrors": []
}

There's incredibly good discussion on some perf traces here in this issue. #4218 I'll still keep this as the primary issue though.

@alyssajotice @fubaduba do you know if this is getting looked at? Performance is one of the most raised issues on this repo.

Example below

Extension	Eager	Load Code	Call Activate	Finish Activate	Event	By
ms-vsliveshare.vsliveshare	true	62	0	3433	*	ms-vsliveshare.vsliveshare

3.4 seconds is a long time for an extension to load, compared to the others which are only in the region of 50ms. Also why is Live Share "eager"? It shouldn't start up unless I'm actively starting it. Which most of the time i'm not using it.

There was already discussion of using onStartupFinished but that still hasn't been looked at.

Linking this too: https://github.com/MicrosoftDocs/live-share/issues/4470.

I will start a conversation with @fubaduba about this.

I can attempt a PR to use onStartupFinished : would it be considered? Anything to take care of when attempting this change?

I can attempt a PR to use onStartupFinished : would it be considered? Anything to take care of when attempting this change?

@aymericbouzy the extension is closed source so I don’t know how you’d manage that.

I hadn't realized haha 😂

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically in 2 days.

Closing in favor of https://github.com/MicrosoftDocs/live-share/issues/4470 which should address this issue.