generative-ai-for-beginners icon indicating copy to clipboard operation
generative-ai-for-beginners copied to clipboard

fix remove locale

Open john0isaac opened this issue 1 year ago • 3 comments

I just noticed that if we remove country locale from embedded video URLs it doesn't work.

I released a new patch of the markdown-checker to fix this issue by skipping the URLs that have video-embed.html at the end of it.

This PR is to fix the rest of the links that still have country locale and will work if we remove them.

cc: @leestott for notification QA.

john0isaac avatar Mar 05 '24 22:03 john0isaac

👋 Thanks for contributing @john0isaac! We will review the pull request and get back to you soon.

github-actions[bot] avatar Mar 05 '24 22:03 github-actions[bot]

Check Country Locale in URLs

We have automatically detected added country locale to URLs in your lessons. Review and remove country specific locale from URLs to resolve this issue.

Check the file paths and associated URLs inside them. For more details, check our Contributing Guide.

File Full Path Issues
./13-securing-ai-applications/README.md ['https://www.microsoft.com/en-us/security/blog/2023/08/07/microsoft-ai-red-team-building-future-of-safer-ai/?WT.mc_id=academic-105485-koreyst']

github-actions[bot] avatar Mar 05 '24 22:03 github-actions[bot]

Didn't know if I should skip this URL too or not.. https://www.microsoft.com/en-us/security/blog/2023/08/07/microsoft-ai-red-team-building-future-of-safer-ai/?WT.mc_id=academic-105485-koreyst

I think there is an issue with the locale resolver as it adds the en correctly but It doesn't add the us so it ends up opening a broken url if we remove the country locale this can probably be solved by the https://microsoft.com team.

john0isaac avatar Mar 05 '24 22:03 john0isaac

Check Country Locale in URLs

We have automatically detected added country locale to URLs in your lessons. Review and remove country specific locale from URLs to resolve this issue.

Check the file paths and associated URLs inside them. For more details, check our Contributing Guide.

File Full Path Issues
./13-securing-ai-applications/README.md ['https://www.microsoft.com/en-us/security/blog/2023/08/07/microsoft-ai-red-team-building-future-of-safer-ai/?WT.mc_id=academic-105485-koreyst']

github-actions[bot] avatar Mar 06 '24 17:03 github-actions[bot]