fast icon indicating copy to clipboard operation
fast copied to clipboard

feat: upgrade to Storybook 8 in `fast-foundation`

Open radium-v opened this issue 3 years ago • 4 comments

🙋 Feature Request

Storybook 7 is now available: https://github.com/storybookjs/storybook/releases

We should see if this new major release offers any improvements to the developer experience when working on Foundation components.

radium-v avatar Apr 03 '23 17:04 radium-v

So I've got this working with @storybook/html-vite but I'm running into issues. Running storybook dev works without any issue but storybook build doesn't seem to actually initialize any of the components and I'm not sure why. I'm thinking it's an issue with esbuild since it doesn't support decorators. Once I get that going, I'll have a PR ready.

As an aside, Vite is pretty great and I think I prefer it to webpack and rollup now.

radium-v avatar Apr 28 '23 18:04 radium-v

So I've got this working with @storybook/html-vite but I'm running into issues. Running storybook dev works without any issue but storybook build doesn't seem to actually initialize any of the components and I'm not sure why. I'm thinking it's an issue with esbuild since it doesn't support decorators. Once I get that going, I'll have a PR ready.

As an aside, Vite is pretty great and I think I prefer it to webpack and rollup now.

You'll need to use @rollup/plugin-typescript or @rollup/plugin-babel with enforce: pre.

@rollup/plugin-swc might work too bet I never tested it. the pre allows it to run before esbuild

ScottAwesome avatar Jun 29 '23 22:06 ScottAwesome

Perhaps some helpful comments here from @evert about exporting and supporting both CJS and ESM https://evertpot.com/universal-commonjs-esm-typescript-packages/ Been referencing this a ton for my own projects

usrrname avatar Jun 29 '23 22:06 usrrname

Storybook 8 is now out 😅

radium-v avatar Mar 19 '24 00:03 radium-v

This appears to be resolved by #6929

janechu avatar May 29 '24 20:05 janechu