PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

PowerToys Run - New plugin checklist: Target framework

Open hlaueriksson opened this issue 1 year ago • 6 comments

Provide a description of requested docs changes

The plugin target framework instruction is old.

https://github.com/microsoft/PowerToys/blob/8bdbeb41d4fe143425648c153c06049d1865380e/doc/devdocs/modules/launcher/new-plugin-checklist.md?plain=1#L34

Should be net8.0-windows.

What target framework requirements does dependencies have now?

hlaueriksson avatar Jan 10 '24 20:01 hlaueriksson

Hi @hlaueriksson I don't think there are strict requirements for dependencies: libraries compatible with .NET 8 should be fine.

In case someone wants to open a PR this line is also outdated since we are now targeting x64 and ARM64: https://github.com/microsoft/PowerToys/blob/8bdbeb41d4fe143425648c153c06049d1865380e/doc/devdocs/modules/launcher/new-plugin-checklist.md?plain=1#L7

davidegiacometti avatar Jan 11 '24 11:01 davidegiacometti

@hlaueriksson , @parvezkhan0, @Bhomesh You are all working on this and we now have three open PRs. We can only merge one.

htcfreek avatar Jan 14 '24 23:01 htcfreek

@htcfreek Which PR do you prefer?

hlaueriksson avatar Jan 14 '24 23:01 hlaueriksson

They are doing exactly the same. I would say the first one.

htcfreek avatar Jan 15 '24 05:01 htcfreek

@hlaueriksson , @parvezkhan0, @Bhomesh You are all working on this and we now have three open PRs. We can only merge one.

@crutkas Which one of the three PRs (#30920, #30927, #30895) should we keep?

htcfreek avatar Jan 15 '24 05:01 htcfreek

I think we keep https://github.com/microsoft/PowerToys/pull/30927/files and https://github.com/microsoft/PowerToys/pull/30920/files . #30895 doesn't seem correct.

jaimecbernardo avatar Jan 17 '24 15:01 jaimecbernardo

Hi, this has been worked on for the 0.78 development cycle. 😄 Please update PowerToys to the latest: https://github.com/microsoft/PowerToys/releases

jaimecbernardo avatar Feb 01 '24 11:02 jaimecbernardo