to-absolute-glob icon indicating copy to clipboard operation
to-absolute-glob copied to clipboard

Published 20 hours ago • verified publisher icon micromatch

fix: Check negative patterns before trimming

Open phated opened this issue 2 years ago • 8 comments

While trying to implement this in glob-stream, I encountered a problem where my negative patterns weren't matching. I traced it to the ./ not being removed in negative globs.

This moves the isNegated check above the trimming logic so the ! will be removed from the pattern before trimming is attempted.

phated avatar Nov 21 '22 21:11 phated

cc @jonschlinkert @doowb

phated avatar Nov 21 '22 21:11 phated

sorry I wasn't feeling well today. I'll take a look tomorrow morning

jonschlinkert avatar Nov 22 '22 04:11 jonschlinkert

No problem. Hope you are feeling better!

If you want to fix the write permissions, I'm happy to wrap these up myself.

phated avatar Nov 23 '22 16:11 phated

Blocking https://github.com/gulpjs/glob-stream/pull/118

phated avatar Nov 23 '22 19:11 phated

cc @jonschlinkert @doowb ping

phated avatar Dec 06 '22 19:12 phated

@jonschlinkert @doowb Hey guys, would it be better if I just fork this and release the stuff that I need? Sorry for being a pain but it is blocking my other work.

phated avatar Dec 09 '22 23:12 phated

@jonschlinkert checking in here. Do you want to get these merged or should I create a new project?

phated avatar Dec 31 '22 20:12 phated

For people looking, the fork is available at https://github.com/gulpjs/to-absolute-glob

phated avatar Jan 03 '23 15:01 phated