Mike Beaumont
Mike Beaumont
It seems like this ultimately stems from the mismatch between "this code is safe to run workflows on with a secret token because it's already in the main repo" vs...
Well, well! Certainly relevant: https://github.com/github/roadmap/issues/107
Hmm it seems `check_suite`/`check_run` events for forked repositories are also useless, since [they don't contain a reference to the pull request](https://developer.github.com/webhooks/event-payloads/#check_suite).
Just commenting to say the current behavior of searching titles for exact matches is, for me, very unintuitive. It also doesn't match buku's behavior, I don't think. If I have...
It looks like setting the arg `--kubeconfig-service-mesh` to a path containing a kubeconfig file for the global cluster works. Flagger running on the zone cluster then creates policies via the...
@stefanprodan I verified that Kuma policies are at least able to be created. It's not clear to me yet in what way that Istio problem would manifest using Kuma but...
Kuma policies are cluster-scoped so I don't think a `TrafficRoute` can get an owner reference to a `Canary` which is namespaced. The `TrafficRoute` is not recreated in a loop like...
Hi, I'm experiencing this issue as well, see https://github.com/weaveworks/eksctl/pull/2561. At https://github.com/weaveworks/eksctl/blob/0f4f59afd63f6b67ce96eba0cf8683bb30ad8384/pkg/gitops/gitops_test.go#L39, which is in package `gitops`, and https://github.com/weaveworks/eksctl/blob/0f4f59afd63f6b67ce96eba0cf8683bb30ad8384/pkg/gitops/url_test.go in package `gitops_test`, I get the error: ``` profile /home/mike/projects/weaveworks/eksctl/pkg/gitops/url_test.go:17 RepositoryURL /home/mike/projects/weaveworks/eksctl/pkg/gitops/url_test.go:18...
Might be my golang ignorance showing here but if `url_test.go` is the only file in `package gitops_test` then we have to call `RunSpecs` there, right?
Ah got it, so once per package directory thingy. That change seems to work, thanks!