jam icon indicating copy to clipboard operation
jam copied to clipboard

Some icons missing a `viewBox` field

Open BBaoVanC opened this issue 3 years ago • 2 comments

I'm trying to use some CSS to modify my icons to be an exact size. It works with most icons, but a few don't have a viewBox parameter, and with those it doesn't work. Should this parameter be added to all of the SVGs?

BBaoVanC avatar May 01 '22 02:05 BBaoVanC

Hey @BBaoVanC, thanks for reporting this issue. Yup, all the 940 icons should already have a viewBox prop. Can you tell me which ones you have trouble with?

michaelampr avatar May 05 '22 08:05 michaelampr

According to a quick search, it looks like these icons are missing a viewBox parameter:

$ grep -L viewBox -r icons/
table-left-header.svg
dice.svg
superscript.svg
dices-f.svg
browse.svg
flashlight-on.svg
telegram.svg
orientaton.svg
dices.svg
code.svg
accessibility.svg
select-all.svg
picture-edit.svg
table-right-header.svg
ltr.svg
text.svg
table-row-above.svg
paragraph.svg
tab.svg
code-sample.svg
subscript.svg
table-cell.svg
intersection.svg
dice-f.svg
table-delete.svg
dribbble.svg
table-cell-merge.svg
page-break.svg
union.svg
table-row-after.svg
gamma.svg
table-col-before.svg
template.svg
star-half-f.svg
table.svg
differenciation.svg
discord.svg
subtraction.svg
rtl.svg
spell-check.svg
table-top-header.svg
table-col-after.svg
quote.svg
character.svg
unlink.svg

I discovered this issue when I was trying to add share icons, and the Telegram one (it's in the list above) wasn't behaving the same as the others when resizing.

BBaoVanC avatar May 05 '22 22:05 BBaoVanC