flower icon indicating copy to clipboard operation
flower copied to clipboard

Version 1.1.0 is not accessible in Docker

Open kaan0nder opened this issue 3 years ago • 11 comments

In Docker Hub, latest version is 1.0.0. Could you upload the latest version (1.1.0) to Docker Hub ?

kaan0nder avatar Aug 01 '22 09:08 kaan0nder

I was just about to open an issue about this myself. In addition to updating latest, can you please also add explicit version tags for the new versions? I'd like to use version 1.1.0 as mher/flower:1.1.0 and not mher/flower:latest or mher/flower:master so that the image I use remains the same (pinned) when you update things.

TomerGodinger avatar Aug 01 '22 12:08 TomerGodinger

Thanks man!

This is still confusing btw. If master is the latest version, that should changed with latest.

kaan0nder avatar Aug 02 '22 06:08 kaan0nder

I don't think it's the latest stable version. From my understanding it's automatically generated when a PR is merged into the master branch. What should happen here is:

  1. A 1.0.0 image should be added. I think that's what latest is right now, so it should be renamed.
  2. A 1.1.0 image should be added.
  3. latest should be set to the 1.1.0 image.
  4. Whenever a new version of Flower is released, a corresponding image should be created and latest changed to point to it.

TomerGodinger avatar Aug 02 '22 07:08 TomerGodinger

Wait, why did you close it? They haven't done this yet.

TomerGodinger avatar Aug 02 '22 07:08 TomerGodinger

As I see, they are not active in Issues tab but, i will still not close this issue.

I have exactly same problems with you.

kaan0nder avatar Aug 02 '22 07:08 kaan0nder

Excellent, thanks for reopening. Even if they don't look here much, it should still be listed as an open issue. As it stands, we currently need to check out the latest release and create the image ourselves, which is pretty ridiculous honestly. I hope they do add this. Should be a quick and easy thing to do.

TomerGodinger avatar Aug 02 '22 09:08 TomerGodinger

version: "3.5" services: flower: hostname: flower image: python:3.9 container_name: flower ports: - "5555:5555" environment: - CELERY_BROKER_URL=pyamqp://username:pasword@rabbitmq-ip:5672// - CELERY_RESULT_BACKEND=redis://username:password@redis-ip:6379 - FLOWER_PORT=5555 command: > sh -c "pip install --user --upgrade pip && pip install --user celery flower && python -m celery --broker=$$CELERY_BROKER_URL --result-backend=$$CELERY_RESULT_BACKEND flower --port=$$FLOWER_PORT"

We found a solution like this. You can use this with flower 1.1.0. It works.

kaan0nder avatar Aug 02 '22 10:08 kaan0nder

Thanks for this. It's unfortunate that many people will use the vulnerable version and have no idea.

shaenr avatar Aug 05 '22 02:08 shaenr

Vulnerable version?

TomerGodinger avatar Aug 07 '22 06:08 TomerGodinger

Now, version 1.2.0 is available: https://hub.docker.com/r/mher/flower/tags

felixriese avatar Aug 08 '22 08:08 felixriese

Excellent, thank you. =) I'd still add the 1.1.0 and 1.0.0 versions in case people want to use them, but at least now there's a pinned updated version available. Good job. :+1:

TomerGodinger avatar Aug 08 '22 10:08 TomerGodinger