Mark Hammond

Results 77 issues of Mark Hammond

Mostly using `{ .. }`, `if let`, and `when Some with (x)` -> `when Some(x)` I did this really just to play with some of the features and pattern matching...

Most of the files here are ignored when in application-services, but when copied into mozilla-central they enable "mach build" to build our megazord and other tooling. ### Pull Request checklist...

With the patch below, the Python test crashes with `fish: Job 1, 'PYTHONPATH=/Users/skip/src/moz/…' terminated by signal SIGSEGV (Address boundary error)` (When running the test you just see a failure but...

We [support `Eq` etc for interfaces](https://mozilla.github.io/uniffi-rs/latest/types/interfaces.html#exposing-methods-from-standard-rust-traits), but not for data classes. I think they'd work well here too.

If we run our tests against Swift 6 we continue to see errors related to `Sendable`. This is true even after #2318 and #2415. In particular, traits and callbacks are...

binding-swift

Executing `UNIFFI_TEST_SWIFT_VERSION=6 cargo test -p uniffi-fixture-futures` will fail with various Sendable conformance issues.

binding-swift

``` pub struct Record { bool: bool, // sad mypy } ``` `cargo test -p uniffi-fixture-keywords-rust` works, but: ``` % mypy target/tmp/uniffi_keywords_rust-xxx/keywords_rust.py .../keywords_rust.py:1161: error: Variable "keywords_rust.RecordWithTypeNames.bool" is not valid as...

Via #2543, our docs for literals in proc-macros aren't great - "String, integer, float, and boolean literals". Also, via UDL, numeric literals carry a radix etc - so we've always...

Eg, a simple enum: https://github.com/mozilla/uniffi-rs/blob/4cbb8f10a1e8171d0b36114f126cb0abeea0f59a/fixtures/ext-types/lib/src/ext-types-lib.udl#L71-L75 If we had an enum with fields, we'd need an `[Enum, Remote] interface {... }`, but that would fail - https://github.com/mozilla/uniffi-rs/blob/aa200a689aa2fca77f8d4b73051c98cdeaecce3c/uniffi_udl/src/attributes.rs#L458 via #2334

get involved