phpstan-drupal

phpstan-drupal copied to clipboard

Call to method Drupal\Core\Entity\Query\QueryInterface::accessCheck() will always evaluate to true (PHPStan 2)

7

# Bug report After upgrading to PHPStan 2, errors related to the `accessCheck()` method occurred. A similar problem was previously solved in #508. Versions used: - phpstan/phpstan `2.1.4` - mglaman/phpstan-drupal...

WalkingDexter

fixes #924

mondrake

Impact of PHPUnit support for regular expressions of #[IgnoreDeprecations] attribute

2

# Bug report PHPUnit's https://github.com/sebastianbergmann/phpunit/pull/6341 introduced a subtle change in the _meaning_ of the `#[IgnoreDeprecations]` attribute in PHPUnit 12.4.0. If before having `#[IgnoreDeprecations]` on a class/method could mean the entire...

mondrake

Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. Release notes Sourced from actions/checkout's releases. v6.0.0 What's Changed Update README to include Node.js 24 support details and requirements by @​salmanmkc in actions/checkout#2248 Persist...

dependabot[bot]

Provide more rules around using code marked as @internal

2

# Feature request We have ClassExtendsInternalClassRule, but there should be more rules that act like PHPStan's `@api` rules: https://github.com/phpstan/phpstan-src/tree/2.1.x/src/Rules/Api So if calling a method, accessing a constant, etc from something...

mglaman

Provide rules to bring type inspection to hooks

1

# Feature request Hooks are not typed and we have no way of knowing what hooks are available in the system, since hooks are not defined and only arbitrarily invoked....

mglaman

Fix $offset type in ItemList::offsetExists

3

Running phpstan against core with `checkFunctionArgumentTypes: true` results in several instances of this error: ``` Parameter #1 $offset of method Drupal\Core\TypedData\Plugin\DataType\ItemList::offsetExists() expects int, Drupal\Core\TypedData\Plugin\DataType\TKey given. ``` Mostly in `ComputedItemListTrait`, but...

mstrelan

`\mglaman\PHPStanDrupal\Type\DrupalClassResolverDynamicReturnTypeExtension` is misleading

1

# Bug report Basically, this extension narrows the type exactly to the argument type. I think it should either be removed or allowed to be disabled. ### Code snippet that...

Niklan

Method Drupal\Core\Form\FormBuilderInterface::getForm() invoked with 2 parameters, 1 required.

1

# Bug report In my project (currently on Drupal 10.5.1), I'm adding an extra parameter in `getForm()` like this: ``` $this->formBuilder->getForm(AccountLoginForm::class, ['param_here' => 'value_here']); ``` Then in `AccountLoginForm.php`, I have...

tlo450

# Bug report Slightly related to the conversation in https://github.com/phpstan/phpstan/issues/6562. PHPstan Drupal currently warns about readonly properties are not supported by DependencySerializationTrait, but that is not necessarily true. Using those...

mxr576