blaze

blaze copied to clipboard

As requested on https://github.com/meteor/blaze/issues/367, I started to migrate code to ES6. All tests are passing, please review and let me know for required changes.

Besides the pr, I found some exported function has no usage in the blaze like isNully, isTagEnsured, etc... should we stop exporting them.

Thank you @guncebektas for this PR. Please note, that we first need to merge #382 before we can continue to work on the actual migrations. Once it's done I will review this one.

@guncebektas I merged #382 to the master branch so you should pull it in to use it to lint your package. Please make sure there are no remaining lint errors. You can read in the CONTRIBUTING file how to use the linter.

This will be hard to achieve :)

Hey @guncebektas sorry that was a bit fast from my side. Of course there may be design decisions from back then that will conflict with the linter. For now please only to non-breaking migrations. All other issues will be discussed during review.

Another thing is, which I mentioned in #385 is that you should please only do one package per PR. Otherwise this gets easily out of hand and becomes impossible to review. For now please keep the scope only to the two packages you worked on.

no problem. I will try to do my best.

It wasn't possible to fulfill all linting rules but I tried to minimize errors. I think a review at this point will be good. All tests of the project are passing.

In addition to this, I used my version as local packages in my project and all of my e2e tests are passing.

I can trust myself and move faster after reviews. @jankapunkt

I just focused on htmljs package for now. My most comments focus on using ES6 builtin functions and syntax in favour of old or depracated syntaxes. Please let's focus first only on htmljs before we continue to html-tools package.

We are getting closer :-)

Are we ok with htmljs @jankapunkt

Once @jankapunkt approves, I will merge this.

Is there a prefered package for the next pr?

hey @guncebektas @StorytellerCZ this is quite a bit to review (which is why in the future there should be only one package per PR) I try to get it done asap the next days!

@guncebektas can you please take a look on @DanielDornhardt comments?