Hi @pianistprogrammer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Apr 20 '24 08:04 facebook-github-bot

I have now registered for the write access to add pull request and signed the Individual Contributor License Agreement

Apr 20 '24 08:04 pianistprogrammer

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Apr 20 '24 10:04 facebook-github-bot

tested on my MacBook Pro M2, and got following error:

RuntimeError: Placeholder storage has not been allocated on MPS device!

@pianistprogrammer Have you tested the PR?

Apr 21 '24 16:04 multics

Same issue for me -> RuntimeError: Placeholder storage has not been allocated on MPS device!

Apr 28 '24 12:04 pygaurav

Same issue for me: RuntimeError: Placeholder storage has not been allocated on MPS device!

May 01 '24 14:05 vishnui