FeedbackEffect icon indicating copy to clipboard operation
FeedbackEffect copied to clipboard

Published 20 hours ago • verified publisher icon mergesort

Impacts are all the same!

Open filipesaz opened this issue 5 years ago • 1 comments

Hi!

You are declaring: let lightImpactGenerator = UIImpactFeedbackGenerator() let heavyImpactGenerator = UIImpactFeedbackGenerator()

Where, it seems to me, you need to be declaring: let lightImpactGenerator = UIImpactFeedbackGenerator.init(style: .light) let heavyImpactGenerator = UIImpactFeedbackGenerator.init(style: .heavy)

Also, you're going to need to code for the fact that .rigid and .soft styles are only available in ios13+.

filipesaz avatar Aug 19 '20 11:08 filipesaz

Hey @filipesaz, I took a quick look and it seems that you're right! I haven't worked on FeedbackEffect in a while, but if you're willing to file a pull request I'd gladly code review and merge it in to make the appropriate changes. Does that sound like something you'd be interested din doing?

mergesort avatar Aug 19 '20 16:08 mergesort