sudo-rs icon indicating copy to clipboard operation
sudo-rs copied to clipboard

Published 20 hours ago • verified publisher icon memorysafety

Add use_pty support

Open squell opened this issue 2 years ago • 3 comments

Do something with the use_pty flag (this runs the spawned process in a seperate pty)

squell avatar Mar 28 '23 13:03 squell

use_pty should not just be implemented, but also be enabled by default, otherwise on Linux there are privilege escalations with TIOCSTI and TIOCLINUX ioctls. See also https://github.com/sudo-project/sudo/issues/258

hannob avatar Apr 27 '23 05:04 hannob

I even wonder if we should keep the nopty behavior for any reason

pvdrz avatar Apr 27 '23 16:04 pvdrz

@pvdrz you mean allowing explicit execution without a PTY versus not supporting that at all? I think it could allow bypassing any potential bugs for known trusted code while the PTY support code is still young?

EDIT: Note to self that pull request #235 and issue #245 are related.

hartwork avatar Apr 27 '23 16:04 hartwork