LightML.jl icon indicating copy to clipboard operation
LightML.jl copied to clipboard

Support for 1.0

Open Roger-luo opened this issue 7 years ago • 4 comments

Is this project abandoned? Any plans for 1.0?

Roger-luo avatar Aug 13 '18 19:08 Roger-luo

See my fork of this repository. In this fork, a large part of the package is compatible with Julia 1.0.

I have not issued PRs for any of these changes, but can do so if desired.

jlapeyre avatar Sep 25 '18 08:09 jlapeyre

On my fork, all of the examples run on v1.0. The repo was not originally designed to be a package, so the code is not organized like a package.

I changed this a bit. But, it is just started.

  1. Move data from ./src to ./resources/data
  2. Rewrite some examples (two or three) as scripts that use the package and put them in ./examples.
  3. Move or copy some code from examples to ./test.

This is all done in many commits, so they may be added selectively.

jlapeyre avatar Oct 03 '18 13:10 jlapeyre

@jlapeyre Great job, thanks for you contribution!

  1. I haven't going around Julia Lang for a while so it may take me some time to pick up the new feature. Is there any plan that you may sent a pull request related to this?

  2. Yes, The repository is not originally designed as a package, it's simply a collection of function and class for learning purpose, so the code structure is a little messy

Thanks!

memoiry avatar Oct 09 '18 02:10 memoiry

Yes. I'd be happy to make a pull request. I made some structural changes. You might not be interested in all of them..... Maybe I can start with just the bare minimum to get most things working with Julia 1.0

jlapeyre avatar Oct 09 '18 19:10 jlapeyre