piping icon indicating copy to clipboard operation
piping copied to clipboard

Set up CI and test against different Node versions

Open grabbou opened this issue 10 years ago • 2 comments

There are reports that it might have broken with Node 4.0 although haven't checked that personally yet. A simple test-case would be much appreciated, CC: @XeeD

grabbou avatar Sep 21 '15 11:09 grabbou

CI would be non-trivial to set up, given the nature of piping. Perhaps a shell script doing something like the following:

  • Create a JS file using piping that outputs 'a'.
  • Run the file in background, and expect the output to be 'a'.
  • Modify the JS file to output 'b'
  • Expect the output to be 'b'.
  • Kill the process.

As piping is only meant to be used in a development environment, I doubt CI is much needed, though; especially if node.js is actually moving to semver.

I briefly tested piping on Windows using Node 4.0, and it seems to work. Do you have more details on what is broken?

mntnoe avatar Sep 23 '15 22:09 mntnoe

Sorry, that was a false alarm from @XeeD and it actually seems to work w/o issues. Even if it's for development, I guess a general test to check if it still reloads would be a nice addition. The suggested behaviour sounds good enough to me.

grabbou avatar Sep 23 '15 23:09 grabbou