Matt Haberland
Matt Haberland
One part of my hesitation with adding a separate function is that if we were to add a function for the statistic used in each of our hypothesis tests, we'd...
Mmm I'm more hesitant to add inputs to functions than outputs, and even more hesitant to add an input that instructs the function to add an output : ) It...
So to sum up @iosonofabio we can continue with this PR. Please consider the adjustments recommended above and I can take a second pass. I'd also suggest adding a unit...
I saw you posted some new commits - are you ready for this to be reviewed again, or was there more to do?
Please see iosonofabio/scipy#1.
The comment about some symmetry was resolved by the two recent commits. (It really crossed paths with the first of them, even though it shows up afterwards.)
Thanks @tirthasheshpatel! @tupui I'm going to merge now but if you have a chance for a quick glance, let me know if there is anything you'd like to change before...
Hi @lispsil, do you plan to finish this up?
> maybe there are better ways to implement .fit? You can see [here](https://github.com/scipy/scipy/issues/11782#issuecomment-729753164) that I was looking into how to fit Weibull on my own. I got to the same...
Hi @lispsil were you still interested in overriding Weibull's fit method? That sounds like it would be a big improvement, as it would also address some other reported issues (gh-11806,...