Mouad Debbar

Results 67 comments of Mouad Debbar

You are right, `server.client` is a regular socket instance returned by `socket.accept()`. It is meant to be private, and people should only use `send()` and `recv()`. I'm not sure I...

hmmm that's an interesting use-case. Using server.client won't help, because the server expects to have only one client at a time. If you try to accept a new connection, it...

I'll be happy to review and accept a Pull Request if you have some time to create one 😊

I'm glad you found this utility helpful @chris-rose-one. Thanks for sharing your example :smile:

When you refresh the page, the entire app is destroyed and launched again. This is how the browser works, nothing specific to Flutter here. So the values of local variables...

How does flutter/flutter detect that it's running on a release branch?

That's a good point. I know on cocoon, we do check that the destination is `master`/`main` before we process the PR: https://github.com/flutter/cocoon/blob/97ad8d020334081d1273a33284d8a4435dfc3af2/app_dart/lib/src/request_handlers/push_gold_status_to_github.dart#L78-L84 I'll look at the Gold config to see...

The only difference between the configs of [flutter/flutter](https://skia.googlesource.com/buildbot/+/refs/heads/main/golden/k8s-instances/flutter/flutter-periodictasks.json5) and [flutter/engine](https://skia.googlesource.com/buildbot/+/refs/heads/main/golden/k8s-instances/flutter-engine/flutter-engine-periodictasks.json5) was made in this [CL](https://skia-review.googlesource.com/c/buildbot/+/523618) a week ago. Before that, both configs were identical.

It looks like Gold bot comments are completely disabled for flutter/flutter (see [CL](https://skia-review.googlesource.com/c/buildbot/+/523618)). I'll disable the Gold bot comments for the flutter/engine repo. If I understand correctly, the golden tests...

> ^ This is the flutter/cocoon bot. It only comments on PRs staged to land on the master/main branch, and ignores release branches. That's right. And as far I can...