Martin Carton
Martin Carton
- Fix review comments from the other PR. - Update dependencies. - Document matches in rustdoc. While [the guide is really good](https://github.com/kriomant/mockers/blob/master/doc/guide.md#argument-matchers), having a comprehensive list of all matchers can...
Just noticed that when refactoring. We could warn when making an iterator [peekable](https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.peekable), but never actually peeking it(/returning it/passing it to a function).
All base64 strings¹ end with a newline character, eg.: ``` python >>> base64.b64decode("dW5kZWZpbmVkCg==") b'undefined\n' >>> base64.b64decode("dW5kZWYK") b'undef\n' >>> base64.b64decode("Q09NMQo=") b'COM1\n' ``` Is this on purpose? That newline character seems pretty...
The current log page is not… well… letś say pretty :sweat_smile: (I mean that page http://clippy.bashy.io/github/Manishearth/rust-clippy/master/log for example)
Eg. ```rust #[derive(derivative::Derivative)] struct Error; ``` should not compile. Less contrived example: ```rust #[derive(derivative::Derivative)] #[derive(Clone)] // user probably meant to use `#[derivative(Clone)]` here struct Error; ``` For instance, the following:...
The following compiles but shouldn't because `Error` is only `PartialEq` and not `Eq`: ```rust #[derive(derivative::Derivative)] #[derivative(PartialEq)] struct Error; #[derive(derivative::Derivative)] #[derivative(PartialEq, Eq)] struct Struct { x: Error, } fn main() {}...
`const` traits aren't stable yet, but we could make the `new` function we optionally generate with `derivative(Debug)` `const`. We wouldn't be able to use `Default::default()` for each field though, so...
This: ```rust #[derive(Debug)] struct Foo { data: Vec, } ``` will always print all vector in a very noisy form. Some filters could be nice: - Print shorter version of...
On enumerations with only simple variants, I've often wanted to have some functions to: - [ ] get all variants (make `const` array? some kind of iterator?) - [ ]...
We should make it an error to use ``` rust #[derivative(PartialEq="ignore")] ``` on a field without a corresponding ``` rust #[derivative(Hash="ignore")] ```