AxisKeys.jl icon indicating copy to clipboard operation
AxisKeys.jl copied to clipboard

Published 20 hours ago • verified publisher icon mcabbott

fixes and updates for Julia 1.9

Open aplavin opened this issue 3 years ago • 3 comments

  • add new: Base.stack for keyed arrays
  • update to match 1.9: Base.uncolon and Base.eachslice

aplavin avatar Sep 06 '22 13:09 aplavin

some tests still fail on nightly

aplavin avatar Sep 06 '22 13:09 aplavin

With new commits, everything should pass on both nightly and older versions.

aplavin avatar Oct 18 '22 10:10 aplavin

CanonicalIndexError should be fixed with https://github.com/JuliaLang/julia/pull/47008

aplavin avatar Oct 18 '22 10:10 aplavin

Julia 1.8.3 indeed fixes that bug, and all tests now pass with no changes from my side.

Anything else I need to modify in this PR?

aplavin avatar Nov 18 '22 08:11 aplavin

Bump @mcabbott This PR makes AxisKeys work with 1.9 and be consistent with that version. Would be great to merge soon, given that 1.9 doesn't seem that far away. Further improvements, such as enabling these features on earlier julias through Compat can be done separately, if needed at all.

aplavin avatar Nov 28 '22 11:11 aplavin

Another bump... @mcabbott

aplavin avatar Dec 22 '22 16:12 aplavin

I'm using the package in my tests and am getting ready for 1.9... but it fails due to the issues addressed in this PR

would be great to have it merged @mcabbott

thorek1 avatar Jan 02 '23 23:01 thorek1

Bump. It would be good to get this one in and released such that we can continue the testing of Julia 1.9

andreasnoack avatar Jan 03 '23 08:01 andreasnoack