agb.plugin icon indicating copy to clipboard operation
agb.plugin copied to clipboard

card: replacing opengraph API dependency

Open goto-bus-stop opened this issue 5 years ago • 3 comments

hi, thanks for publishing these blocks! I'd love to use the card block but i would prefer not to depend on a third party service for it. Would you be open to a PR that replaces the opengraph.io requests by a WordPress Ajax action to retrieve the embed data using the embed/embed library?

Thanks!

goto-bus-stop avatar Jul 02 '20 18:07 goto-bus-stop

I used to do this on the previous version but I had al ot of troubles getting the right data, so I switched to an external service for more simplicity.

This is a good idea to use this library, sadly I have no time to maintain this plugin anytime soon. I'm looking or contributors if you're interested.

maximebj avatar Jul 03 '20 07:07 maximebj

I used to do this on the previous version but I had al ot of troubles getting the right data, so I switched to an external service for more simplicity.

This is a good idea to use this library, sadly I have no time to maintain this plugin anytime soon. I'm looking or contributors if you're interested.

Could you at least push the updates to sanitize the output from the plugin?

That would probably be the most urgent thing to implement as of now.

w3bdesign avatar Jul 04 '20 13:07 w3bdesign

This is a good idea to use this library, sadly I have no time to maintain this plugin anytime soon. I'm looking or contributors if you're interested.

I probably can't commit to any maintainership either, and I also don't know enough about wordpress to do that confidently. I did open a PR for the feature from this issue at https://github.com/maximebj/agb.plugin/pull/63. If you have a chance to look at it, great, if not, no matter :) Thanks for the response!

e; since I do use the card block in a site, I'm of course happy to work on any issues I do find :)

goto-bus-stop avatar Jul 04 '20 14:07 goto-bus-stop