Max Bachmann

Results 261 comments of Max Bachmann

Using `__pragma` or since C++11/c99 `_Pragma` might be a good solution for constant expression warnings as well.

> I'd rather not mix this into arbitrary statements. Having a separate marker 'command' feels better to me. what do you mean with `separate marker 'command'`

@scoder do we still want to get the other changes here in? I could get them finished, but I am unsure whether the warnings are worth the trouble. At this...

From my pov this is not really worth these changes, so closing this for now

Is there anything except https://github.com/cython/cython/issues/4280 that is still needed for a final Cython 3 release?

Mentioning the related issue here, so github links them: #4539

Same problem here. I just could not get `add_cython_target` to work when providing a different path like e.g. ```cmake add_cython_target(cpp_utils src/cpp_utils.pyx CXX PY3) ``` which results in the error: ```...

@henryiii I just realized this does not only break my local builds, but some CI release builds as well: https://www.piwheels.org/logs/0000/0876/8971.txt For now I workaround the issue by using `0.14.1` on...

As an update: hardcoding `0.14.1` fixed my local problems, but the problems in the CI build still occur. Python3.7, scikit-build 0.14.1, cmake 3.16: https://www.piwheels.org/logs/0000/0878/0515.txt -> working Python3.9, scikit-build 0.14.1, cmake...

I am unsure when `get_requires_for_build_sdist` is called. Is this called to collect requirements to convert from source to sdist, or to build from the sdist? As far as I understand...