electron-oauth2 icon indicating copy to clipboard operation
electron-oauth2 copied to clipboard

Exception due to window already destroyed

Open rogeru opened this issue 8 years ago • 1 comments

In my case I get 'will-navigate' and a 'did-get-redirect-request' which means onCallback is called a second time. Resolving a promise a second time does not harm, but the window is already close on the first callback and therefore an exception is raised when trying to access it or close it again.

Another minor issue is that opts.additionalTokenRequestData throws an exception if no options object is passed in.

I will create a pull request.

rogeru avatar Oct 19 '17 21:10 rogeru

Thanks for the PR, I'll review it soon and hopefully merge it (I'm new at helping maintain this repo, so it might take a little bit).

aguynamedben avatar Apr 07 '18 05:04 aguynamedben