Matt Hegarty

Results 46 issues of Matt Hegarty

**Problem** PR for v4 release - Removed MANIFEST.in - [no longer required](https://pypi.org/project/setuptools-scm/) when using setuptools-scm - Updated coveralls in CI to use github action because `cannot import name 'Reporter' from...

v4

**Describe the bug** If you import a file with no headers via the Admin Console then there is no error message to the user, instead a blank confirm screen is...

bug
v4
Admin UI

**Describe the bug** [`diff_match_patch`](https://github.com/google/diff-match-patch/issues/143) seems unmaintained. it looks like there is a [maintained fork](https://github.com/dmsnell/diff-match-patch/tree/issues/69-broken-surrogate-pairs). This library is used to show the differences between persisted and imported values. It is presented...

chore

[tablib 4 is coming](https://github.com/jazzband/tablib/issues/558#issuecomment-1715501213). We should upgrade in v4 due to the breaking changes described [here](https://github.com/jazzband/tablib/issues/558). At present [test](https://github.com/django-import-export/django-import-export/blob/1c8e38c27abe3f6088da74c6a806e4092c87cd0c/tests/core/tests/test_base_formats.py#L213) is removed until tablib v4 is released. Note I cannot pin...

v4

I am trying to remove the phonenumbers dependency, but it looks like it is required. The documentation states: > This project uses django-phonenumber-field which requires either phonenumbers or phonenumberslite to...

I made some minor changes to get this example to work with django-rest-framework-jwt (without affecting the core example). Firstly, calls to DRF failed because of HTTP 415 (unsupported media type)...

**Describe the bug** `resource_class` was removed in v4 in favour of `resource_classes`. However the following declaration still works: ``` class BookAdmin(ImportExportModelAdmin): list_display = ("name", "author", "added") list_filter = ["categories", "author"]...

bug

**Describe the bug** in v3, all model fields are presented during import: ![image](https://github.com/django-import-export/django-import-export/assets/6249838/79ed7332-adf2-44dd-ad99-a6a0d8ca1cd8) In v4, only certain model fields are presented, even when no `fields` attribute is defined. ![image](https://github.com/django-import-export/django-import-export/assets/6249838/f21f04b3-7853-443f-a393-520b43c06e5b) **To...

bug
Admin UI

**Describe the bug** #1755 added a formatted error if a file was imported with a badly formed header. However this behaviour currently does not occur: ![image](https://github.com/django-import-export/django-import-export/assets/6249838/9030a69e-f62c-4d22-8434-d940f7b5a515) This also means that...

bug

Extension to #149 which includes the params passed into the parent method. This is useful if the override of count needs to depend on other params. Note this will break...