Matthew Feickert

Results 460 comments of Matthew Feickert

> This has been reported to `nbconvert` in [jupyter/nbconvert#1736](https://github.com/jupyter/nbconvert/issues/1736), and it has been fixed in [jupyter/nbconvert#1737](https://github.com/jupyter/nbconvert/pull/1737), which should be available in the latest `nbconvert` release 6.4.5. > > Please upgrade...

I made Issue #645 so that this Issue doesn't get drawn off topic and become less useful to other people coming here for the original motivation. Apologies in advance if...

> Just to make sure there's no misunderstanding: You are suggesting to add `nbconvert>=6.4.5` to `install_requires`, right? Not necessarily and probably not. I would more specifically suggest to emperically evaluate...

I just wanted to :heavy_plus_sign: this issue for the same reasons as @joleroi and follow any developments. We also have [such issues for our code examples in pyhf](https://scikit-hep.org/pyhf/_generated/pyhf.tensor.pytorch_backend.pytorch_backend.html#pyhf.tensor.pytorch_backend.pytorch_backend.simple_broadcast), so this...

> I think this should be ready for formal review now. Thanks very much @beojan. We have a few other PRs that we're trying to prioritize for the `v0.6.0` release,...

@beojan believe it or not, we haven't forgotten about this PR :grimacing:. We're just trying to make sure that we have some particular pieces in for a patch release before...

> I was wondering whether there has been any further advance on this issue. This will be going into `v0.7.0`, but because we wanted this to go into a minor...

> I could try and rebase this PR later this week. You're welcome to do that (and I usually like rebasing PRs of my own to keep things clear on...

> `intervals.upper_limits.upper_limit` and `intervals.upperlimit` is very confusing. Is there a way to clean this API up slightly? Otherwise, the rest looks good to me. I'd typically prefer if we don't...

For reasons unclear to me we're currently being blocked by Issue #2015, which is only happening with this PR/these changes. :?