Matt Mackay

Results 41 comments of Matt Mackay

Does the functionality exist in our previous version of gen internally? I think it generated the `ts_web_test` and `ng_web_test` macros. Do we still want that here or should it gen...

Seems reasonable, we should look to add `ng_web_test` and `ts_web_test` to the index.bzl here. I quite like those as macros anyway.

TODO: - [ ] add instructions to readme for installation etc - [ ] update ev sync to handle the new folder paths - [ ] add tests, from quick...

rules_python sandwich breaks, ie `py_library (rules_py)` -> `py_library (rules_python)` -> `py_binary (rules_py)` breaks dependency import paths.

I'm not clear if there's work for us to do here, or this can be closed?

Opened upstream issue https://youtrack.jetbrains.com/issue/IDEA-294464/pth-files-inside-a-venv-site-packages-is-ignored with minimal non-bazel repro https://github.com/mattem/ij-venv-pth

Fixed by https://github.com/aspect-build/rules_py/pull/233

I'm not sure we'd want to manipulate the `PYTHONPATH` here, as we'd be back in the same set of issues that users experience under rules_python, this would also not work...

Yah good point, `$0` or configure a product name is better here.