dokku-secure-apps icon indicating copy to clipboard operation
dokku-secure-apps copied to clipboard

Fix commands not being processed consistently

Open chikamichi opened this issue 7 years ago • 2 comments

Hi,

I noticed running dokku secure-apps:help doesn't work, and actually there seems to be two issues:

  • the plugin itself is named secure-apps, but the commands are secure:*
  • the secure:help is not reachable due to the way commands is implemented (initial check for args)

I'd propose fixing those issues by:

  • supporting the secure-apps:* namespace along the legacy secure:* one, maybe displaying a notice that using the latter is prefered
  • rework :help, taking inspiration from, let's say, https://github.com/dokku/dokku-letsencrypt/blob/master/commands

chikamichi avatar Oct 07 '18 12:10 chikamichi

I have granted you edit access to the repository so you are able to help maintain the plugin and fix issues like these.

If you like, you can still submit changes are PRs and I'm happy to review them, however, I haven't used Dokku in many years so my knowledge of Dokku is very out-of-date.

matt-oakes avatar Oct 14 '18 15:10 matt-oakes

Thank you!

chikamichi avatar Oct 14 '18 16:10 chikamichi