mjolnir

mjolnir copied to clipboard

Describe the bug After starting Mjolnir when it has been down for a couple hours it does a lot of work repeatedly.

The log is much too long to paste here but it does every step of its startup many times for every room it is in. For example, the following very small snippet of the startup log took place across about 2 seconds:

Updating member bans in Nix* Documentation
Updating member bans in Nix* Documentation
Updating member bans in #nixos-de
Updating member bans in Nix Cross Compiling
Updating member bans in Nix* Documentation
Updating member bans in Nix* Documentation
Updating member bans in Nix* Documentation
Updating member bans in Nix Cross Compiling
Updating member bans in Nix* Documentation
Updating member bans in !xkSgPynYYzyKPtWvcA:nixos.org
Updating member bans in Nix* Documentation
Updating member bans in Nix Cross Compiling
Updating member bans in Nix* Documentation
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Cross Compiling
Updating member bans in Nix Cross Compiling
Updating member bans in Nix Python
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Cross Compiling
Updating member bans in Nix Cross Compiling
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Cross Compiling
Updating member bans in Nix Cross Compiling
Updating member bans in Nix* Documentation
Updating member bans in Nix Cross Compiling
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Cross Compiling
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix / Nixpkgs / NixOS Dev
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Matrix Discussion
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Cross Compiling
Updating member bans in Nix Matrix Discussion
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in Nix Matrix Discussion
Updating member bans in Staging
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in Staging
Updating member bans in !xkSgPynYYzyKPtWvcA:nixos.org
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in Staging
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in Nix Matrix Discussion
Updating member bans in Staging
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in deploy-rs
Updating member bans in Staging
Updating member bans in Staging
Updating member bans in deploy-rs
Updating member bans in Nix* Documentation
Updating member bans in Staging
Updating member bans in Staging
Updating member bans in deploy-rs
Updating member bans in Staging
Updating member bans in Staging
Updating member bans in Staging
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in deploy-rs
Updating member bans in Staging
Updating member bans in Nix Language
Updating member bans in deploy-rs
Updating member bans in deploy-rs
Updating member bans in Nix Language
Updating member bans in Nix Cross Compiling
Updating member bans in deploy-rs
Updating member bans in deploy-rs
Updating member bans in Nix Language
Updating member bans in deploy-rs
Updating member bans in deploy-rs
Updating member bans in deploy-rs
Updating member bans in Nix Language
Updating member bans in deploy-rs
Updating member bans in Staging
Updating member bans in NixOS Gaming
Updating member bans in Nix Language
Updating member bans in Nix Language
Updating member bans in NixOS Gaming
Updating member bans in Nix Matrix Discussion
Updating member bans in Nix Language
Updating member bans in Nix Language
Updating member bans in NixOS Gaming
Updating member bans in Nix Language
Updating member bans in Nix Language
Updating member bans in Nix Language
Updating member bans in NixOS Gaming
Updating member bans in Nix Language
Updating member bans in deploy-rs
Updating member bans in Hydra
Updating member bans in NixOS Gaming
Updating member bans in NixOS Gaming
Updating member bans in Hydra
Updating member bans in NixOS.org Infrastructure Alerts 🚨
Updating member bans in NixOS Gaming
Updating member bans in NixOS Gaming
Updating member bans in Hydra
Updating member bans in NixOS Gaming
Updating member bans in NixOS Gaming
Updating member bans in NixOS Gaming
Updating member bans in Hydra
Updating member bans in NixOS Gaming
Updating member bans in Nix Language
Updating member bans in NixOS Security
Updating member bans in Hydra
Updating member bans in Hydra
Updating member bans in NixOS Security
Updating member bans in Staging
Updating member bans in Hydra
Updating member bans in Hydra
Updating member bans in NixOS Security
Updating member bans in Hydra
Updating member bans in Hydra
Updating member bans in Hydra
Updating member bans in NixOS Security
Updating member bans in Hydra
Updating member bans in NixOS Gaming
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS Security
Updating member bans in NixOS Security
Updating member bans in NixOS.org Infrastructure
Updating member bans in deploy-rs
Updating member bans in NixOS Security
Updating member bans in NixOS Security
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS Security
Updating member bans in NixOS Security
Updating member bans in NixOS Security
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS Security
Updating member bans in Hydra
Updating member bans in Nix-Gui
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS.org Infrastructure
Updating member bans in Nix-Gui
Updating member bans in Nix Language
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS.org Infrastructure
Updating member bans in Nix-Gui
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS.org Infrastructure
Updating member bans in Nix-Gui
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS Security
Updating member bans in Teams
Updating member bans in Nix-Gui
Updating member bans in Nix-Gui
Updating member bans in Teams
Updating member bans in NixOS Gaming
Updating member bans in Nix-Gui
Updating member bans in Nix-Gui
Updating member bans in Teams
Updating member bans in Nix-Gui
Updating member bans in Nix-Gui
Updating member bans in Nix-Gui
Updating member bans in Teams
Updating member bans in Nix-Gui
Updating member bans in NixOS.org Infrastructure
Updating member bans in Flakes
Updating member bans in Teams
Updating member bans in Teams
Updating member bans in Flakes
Updating member bans in Hydra
Updating member bans in Teams
Updating member bans in Teams
Updating member bans in Flakes
Updating member bans in Teams
Updating member bans in Teams
Updating member bans in Teams
Updating member bans in Flakes
Updating member bans in Teams
Updating member bans in Nix-Gui
Updating member bans in NixOS Systemd
Updating member bans in Flakes
Updating member bans in Flakes
Updating member bans in NixOS Systemd
Updating member bans in NixOS Security
Updating member bans in Flakes
Updating member bans in Flakes
Updating member bans in NixOS Systemd
Updating member bans in Flakes
Updating member bans in Flakes
Updating member bans in Flakes
Updating member bans in NixOS Systemd
Updating member bans in Flakes
Updating member bans in Teams
Updating member bans in NixOS + TPMs
Updating member bans in NixOS Systemd
Updating member bans in NixOS Systemd
Updating member bans in NixOS + TPMs
Updating member bans in NixOS.org Infrastructure
Updating member bans in NixOS Systemd
Updating member bans in NixOS Systemd
Updating member bans in NixOS + TPMs
Updating member bans in NixOS Systemd
Updating member bans in NixOS Systemd
Updating member bans in NixOS Systemd
Updating member bans in NixOS + TPMs
Updating member bans in NixOS Systemd
Updating member bans in Flakes
Updating member bans in OfBorg
Updating member bans in NixOS + TPMs
Updating member bans in NixOS + TPMs
Updating member bans in OfBorg
Updating member bans in Nix-Gui
Updating member bans in NixOS + TPMs
Updating member bans in NixOS + TPMs
Updating member bans in OfBorg
Updating member bans in NixOS + TPMs
Updating member bans in NixOS + TPMs
Updating member bans in NixOS + TPMs
Updating member bans in OfBorg
Updating member bans in NixOS + TPMs
Updating member bans in NixOS Systemd
Updating member bans in #nixos.de
Updating member bans in OfBorg
Updating member bans in OfBorg
Updating member bans in #nixos.de
Updating member bans in Teams
Updating member bans in OfBorg
Updating member bans in OfBorg
Updating member bans in #nixos.de
Updating member bans in OfBorg
Updating member bans in OfBorg
Updating member bans in #nixos.de
Updating member bans in OfBorg
Updating member bans in OfBorg
Updating member bans in NixOS + TPMs
Updating member bans in #nixos.de
Updating member bans in #nixos.de
Updating member bans in Flakes
Updating member bans in #nixos.de
Updating member bans in #nixos.de
Updating member bans in #nixos.de
Updating member bans in #nixos.de
Updating member bans in #nixos.de
Updating member bans in #nixos.de
Updating member bans in OfBorg
Updating member bans in NixOS Systemd
Updating member bans in #nixos.de
Updating member bans in NixOS + TPMs
Updating member bans in OfBorg
Updating member bans in #nixos.de
Startup complete. Now monitoring rooms.

This is also true about other steps in startup, like verifying ACLs. Every one of these applies many many times to every channel.

This causes enormous amounts of spew to the management room and causes startup to take a long time.

I would instead expect it to update member ban and verify ACLs once per room.

To Reproduce Steps to reproduce the behavior:

1. Have mjolnir in a bunch of busy rooms
2. Stop mjolnir for a few hours
3. Start mjolnir

This is with Mjolnir v1.2.1.

@jesopo has read access to the moderation room this took place in.

Hey @grahamc, at least for the message spam there is a config value for that https://github.com/matrix-org/mjolnir/blob/main/config/default.yaml#L49 which should stop these "Updating member bans" messages.

I think what we are seeing here is Mjolnir syncing to catch up from the last time it was turned on and processing every event since.

I don't mind those messages per-room, however every time the bot starts it prints each room many times. It is indeed catching up, but I think there is something else going on. Every room has their member bans updated the same number of times, seemingly 14.