mathnet-spatial icon indicating copy to clipboard operation
mathnet-spatial copied to clipboard

Published 20 hours ago • verified publisher icon mathnet

Inconsistent return type for Matrix3D.RotationAround{X|Y|Z}Axis(angle) #question

Open olvd opened this issue 9 years ago • 2 comments

Is there a reason for MathNet.Spatial.Euclidean.Matrix3D.RotationAround{X|Y}Axis(angle) returning a DenseMatrix and MathNet.Spatial.Euclidean.Matrix3D.RotationAroundZAxis(angle) returning a Matrix<double> or is it just a typo?

olvd avatar Apr 04 '16 12:04 olvd

This looks wrong. @cdrnet what is the most correct type here? Ideally Matrix3D should be rewritten returning a struct Matrix3D Thanks for creating the issue.

JohanLarsson avatar Apr 04 '16 20:04 JohanLarsson

Yes, I'd expect a Matrix3D as well, in both cases.

cdrnet avatar Apr 04 '16 20:04 cdrnet