meteor-ios icon indicating copy to clipboard operation
meteor-ios copied to clipboard

Compile to OS X

Open mathieutozer opened this issue 10 years ago • 24 comments

After a very quick glance at the code, it seems as though this could be made to target OS X. What do you think?

mathieutozer avatar Feb 14 '15 00:02 mathieutozer

I haven't tested it myself, but I don't see any principled reason why it couldn't work on OS X. Out of the top of my head the only real dependency right now is the application lifecycle and network reachability code. It shouldn't be too difficult to factor that out. I've actually stopped using CocoaPods in my own code and will add a project with a framework target soon. That should make it easier to support a separate OS X target.

martijnwalraven avatar Feb 14 '15 02:02 martijnwalraven

I took a closer look and yes I think with some compile time flags it could be easy to do. On 2015年2月13日(金) at 18:53 Martijn Walraven [email protected] wrote:

I haven't tested it myself, but I don't see any principled reason why it couldn't work on OS X. Out of the top of my head the only real dependency right now is the application lifecycle and network reachability code. It shouldn't be too difficult to factor that out. I've actually stopped using CocoaPods in my own code and will add a project with a framework target soon. That should make it easier to support a separate OS X target.

— Reply to this email directly or view it on GitHub https://github.com/martijnwalraven/meteor-ios/issues/4#issuecomment-74358486 .

mathieutozer avatar Feb 14 '15 02:02 mathieutozer

Do you think this is likely to happen? I am about to start a project that will have an iOS and OS X application and would very much like to use this framework in them both?

Thanks

Gareth

gazzer82 avatar Mar 30 '15 21:03 gazzer82

You'd have to spend some time removing iOS dependencies from the code and configuring the CocoaPods spec for both platforms (or set up separate framework targets), but I don't foresee any real trouble. I'm not sure when I'll get to this myself, as I'm not working on OS X apps right now, but it is on my to do list.

martijnwalraven avatar Mar 31 '15 02:03 martijnwalraven

I took a look at it myself and found that the SimpleKeychain dependency to be the non trivial part. Everything else was pretty simple. Martjin what role does the keychain play? Could it be sidestepped for now so that we could move forward?

mathieutozer avatar Apr 10 '15 18:04 mathieutozer

I've got it to compile by compiling out iOS specific pieces, and without having to comment out too much code ;)

I'm going to take it for a spin in one of my projects and if all goes well I'll put up a pull request.

mathieutozer avatar Apr 18 '15 20:04 mathieutozer

Let me know how it goes. I'm in the process of making a few other changes to the project structure, so maybe you should wait for them to land before working on a pull request. We would also have to add separate targets for iOS and OS X, and change the Podspec.

martijnwalraven avatar Apr 21 '15 16:04 martijnwalraven

Yep, I've already updated the podspec. The changes were minimal (they took maybe 10 minutes to compile out with compile time flags) so go ahead.

On Tue, Apr 21, 2015 at 9:02 AM Martijn Walraven [email protected] wrote:

Let me know how it goes. I'm in the process of making a few other changes to the project structure, so maybe you should wait for them to land before working on a pull request. We would also have to add separate targets for iOS and OS X, and change the Podspec.

— Reply to this email directly or view it on GitHub https://github.com/martijnwalraven/meteor-ios/issues/4#issuecomment-94853630 .

mathieutozer avatar Apr 21 '15 18:04 mathieutozer

Mathieu, can you publish an example OS X project that uses this meteor framework?

Dev1an avatar Apr 24 '15 11:04 Dev1an

I had to update a sub dependency to support the OS X version of meteor-ios, so I guess I have to have that pulled first and then make another for meteor-ios.

Embarrassingly this is my first github pull request

mathieutozer avatar Apr 26 '15 17:04 mathieutozer

First pull request for SimpleKeychain in case anyone wants to take a look

https://github.com/mathieutozer/SimpleKeychain/commit/2b6d2604be84b2a1f52299e615921ca4eb9697e0?diff=split

mathieutozer avatar Apr 28 '15 23:04 mathieutozer

Working version of Leaderboard for OS X screen shot 2015-04-28 at 4 59 11 pm

mathieutozer avatar Apr 28 '15 23:04 mathieutozer

Can you put the source code of your OSX leaderbord example online?

Dev1an avatar May 06 '15 22:05 Dev1an

I was waiting for the pull request for simple keychain to get done, do you have a local working version of meteor for os x running and want to see how to make a mac os x leaderboard app or can you wait until the official pull request is ready?

On Wed, May 6, 2015 at 3:12 PM Devian [email protected] wrote:

Can you put the source code of your OSX leaderbord example online?

— Reply to this email directly or view it on GitHub https://github.com/martijnwalraven/meteor-ios/issues/4#issuecomment-99626190 .

mathieutozer avatar May 07 '15 00:05 mathieutozer

Ok I've pushed a shaky version to https://github.com/mathieutozer/meteor-ios

I am still waiting for a pull request for SimpleKeychain to happen before making an official PR for meteor-ios, I can't work out how to reference my fork with the podspecs (and some googling tells me it is not possible anyway) so I just copied the keychain source into the meteor pod for now to share how this looks.

Also for some reason with this change the test target in the generated workspace is screwed up. If anyone can clone take a look that would be appreciated!

mathieutozer avatar May 11 '15 22:05 mathieutozer

Any more progress on this? I can help; I have a big paying project that could use this.

ssteinerx avatar Jul 25 '15 22:07 ssteinerx

Hey I haven't worked on this for a while, I ran into a pretty nasty rebase. If you want to pick it up while I'm on vacation, go ahead!

mathieutozer avatar Aug 03 '15 19:08 mathieutozer

What's the nasty rebase, where are you at, and what can I do to help move it along?

ssteinerx avatar Aug 03 '15 23:08 ssteinerx

Just rebasing my fork onto the latest master was pretty bad - maybe start there?

On Mon, Aug 3, 2015 at 7:01 PM Steve Steiner [email protected] wrote:

What's the nasty rebase, where are you at, and what can I do to help move it along?

— Reply to this email directly or view it on GitHub https://github.com/martijnwalraven/meteor-ios/issues/4#issuecomment-127427403 .

mathieutozer avatar Aug 05 '15 22:08 mathieutozer

+1

freysie avatar Nov 12 '15 16:11 freysie

For people following along the master in this fork should work. Someone try it out?

https://github.com/mathieutozer/meteor-ios

mathieutozer avatar Nov 14 '15 01:11 mathieutozer

Cool, @mathieutozer. I’ll check it out asap!

Does it include your OS X leaderboard sample?

freysie avatar Nov 14 '15 03:11 freysie

Yes it does!

On Fri, Nov 13, 2015 at 7:39 PM Jakob Alminde [email protected] wrote:

Cool, @mathieutozer https://github.com/mathieutozer. I’ll check it out asap!

Does it include your OS X leaderboard sample?

— Reply to this email directly or view it on GitHub https://github.com/martijnwalraven/meteor-ios/issues/4#issuecomment-156620032 .

mathieutozer avatar Nov 16 '15 21:11 mathieutozer

DUDE, SWEET!

freysie avatar Nov 17 '15 17:11 freysie