create-react-app-buildpack icon indicating copy to clipboard operation
create-react-app-buildpack copied to clipboard

specified a static heroku-buildpack-nodejs version. fixes issue #181

Open jpvillaseca opened this issue 4 years ago • 2 comments

Since the latest version of heroku-buildpack-nodejs is not the master branch, they recommend referencing specific versions by using tags, since master could (and is) unstable.

At the moment, heroku-buildpack-nodejs doesn't have a "latest" tag of sorts, so we have to put the latest version tag manually.

It fixes issue #181 related to dokku deployments failing due to that buildpack.

jpvillaseca avatar Nov 09 '20 13:11 jpvillaseca

Hi! I don't think pinning the Node.js buildpack is the best choice here. The Dokku base image should be updated to include jq instead, for parity with the Heroku stack images. (And in fact, I'm pretty sure the latest Herokuish images are based on the Heroku stack images, so perhaps you just need a docker pull?)

edmorley avatar Nov 16 '20 15:11 edmorley

@jpvillaseca fwiw Heroku has added a latest tag

mladenoff avatar Nov 17 '20 23:11 mladenoff