mailtoui icon indicating copy to clipboard operation
mailtoui copied to clipboard

Published 20 hours ago • verified publisher icon mariordev

Missing var declaration for toggleCopyButton function

Open francoismajor opened this issue 5 years ago • 3 comments

This returns an error. (button is not defined) The function still works, but 'Copied!' text is not displayed.

https://github.com/mariordev/mailtoui/blob/1be162bdd3d964c3ad61a8423884640b95d33da5/src/js/mailtoui.js#L874 https://github.com/mariordev/mailtoui/blob/1be162bdd3d964c3ad61a8423884640b95d33da5/src/js/mailtoui.js#L875

Simple fix: var button = document.getElementById(t.prefix('-button-copy')); var buttonText = document.getElementById(t.prefix('-button-text-copy'));

francoismajor avatar Jul 08 '20 16:07 francoismajor

Just ran into the same issue today, when executing mailtoui under strict mode.

Fixed it here. Let me know if you want me to submit a pull request. 👍

janogarcia avatar Aug 18 '20 15:08 janogarcia

Hi @janogarcia, Thank you for letting me know. No need to submit a pr, I'll get this fix in as soon as I can. Thanks!

mariordev avatar Aug 18 '20 20:08 mariordev

Hi @francoismajor, thanks for pointing this out! I'll get this fix in as soon as I can.

mariordev avatar Aug 18 '20 21:08 mariordev