martin icon indicating copy to clipboard operation
martin copied to clipboard

SSL, HTTP/2 support

Open H-Plus-Time opened this issue 6 years ago • 4 comments

So Actix added SSL a while back (marginal benefit really), and recently HTTP/2; I've confirmed that both work behind nginx (or whichever other reverse proxy you care to use), though it would be nice for dev purposes to be able to run it standalone with HTTP/2, given the noticeable queueing effect incurred by HTTP/1.1 (irrespective of load on the database workers).

I'll tinker with it over the coming weekend (should be relatively straightforward), would you mind if I submit a PR to that effect?

H-Plus-Time avatar Jun 24 '19 04:06 H-Plus-Time

Hey @H-Plus-Time! Thanks for filling an issue for that! I'll gladly review a PR for this.

stepankuzmin avatar Jun 24 '19 07:06 stepankuzmin

I tried to deploy this docker image on heroku and it fails on database connection because Heroku enforces SSL connections only. Is this a known issue?

I see this issue in the rust-postgres library and unsure if that's what am running into:

https://github.com/sfackler/rust-postgres/issues/297

Do you have any recommendations on how I get around it?

Thanks!

shaunakv1 avatar Oct 01 '19 07:10 shaunakv1

Hi @shaunakv1!

Could you please create a separate issue for this and provide steps to reproduce?

stepankuzmin avatar Oct 01 '19 11:10 stepankuzmin

Should this be closed? We are now using the latest actix framework. I don't know the context of this issue, please close if no longer relevant.

nyurik avatar Sep 16 '22 02:09 nyurik

i think we already support all this

nyurik avatar Sep 28 '22 08:09 nyurik