mapbox-navigation-ios icon indicating copy to clipboard operation
mapbox-navigation-ios copied to clipboard

User puck should rotate according to heading, not course

Open 1ec5 opened this issue 3 years ago • 4 comments

When following a walking route, the user puck should rotate according to the heading (the direction the device is facing), not the course (the direction in which the device is moving). Currently it always rotates according to the course, regardless of the routing profile:

https://github.com/mapbox/mapbox-navigation-ios/blob/793a34f2f24c9e4eaec2f94079b245cc717b20f2/Sources/MapboxNavigation/NavigationMapView.swift#L906

We should set LocationOptions.puckBearingSource to PuckBearingSource.heading when the current route’s profile identifier is walking. Unfortunately, this option is being set inside NavigationMapView, which doesn’t have much context about the route. We could set it based on one of the routes in routes, but maybe NavigationViewController should override it based on what it knows the current route to be.

The correct behavior for walking navigation was introduced in #3620, but it effectively regressed in #3123 when we delegated the responsibility for updating the puck’s location and direction to the map SDK without setting the puck bearing source.

/ref mapbox/mapbox-maps-ios#428 /cc @mapbox/navigation-ios @jinny-nam

1ec5 avatar Aug 10 '22 19:08 1ec5

We also have issue with heading when using walking profile and when device is in landscape mode.

MaximAlien avatar Aug 22 '22 17:08 MaximAlien

landscape mode related issue: https://github.com/mapbox/mapbox-navigation-ios/issues/1942#issuecomment-479585406

jill-cardamon avatar Aug 22 '22 17:08 jill-cardamon

Hi, just checking in. This ticket has been open for 4 months. Is there a plan to deliver a fix soon?

karldusenbery avatar Mar 13 '23 19:03 karldusenbery

Hi, just checking in. This ticket has been open for 1 year. Is there a plan to deliver a fix soon?

karldusenbery avatar Aug 01 '23 20:08 karldusenbery