mapbox-gl-js icon indicating copy to clipboard operation
mapbox-gl-js copied to clipboard

Fix blank globe on Android by reverting "Prevent unnecessary terrain define with globe"

Open SnailBones opened this issue 3 years ago • 0 comments

This reverts commit 7aa71e9af52971ffab762c4bcdca4fdac146963d.

Fixes a regression introduced in https://github.com/mapbox/mapbox-gl-js/pull/12039 where the globe (without terrain and at low zoom) shows up blank on Android devices. Tested in Chrome and Firefox.

Before: Screenshot from 2022-08-10 11-06-57

After:

Screenshot from 2022-08-10 11-08-39

Benchmark here

Fixing on main tracked in https://github.com/mapbox/mapbox-gl-js/pull/12152

Launch Checklist

  • [x] briefly describe the changes in this PR
  • [ ] include before/after visuals or gifs if this PR includes visual changes
  • [ ] document any changes to public APIs
  • [x] post benchmark scores
  • [X] manually test the debug page
  • [X] apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

SnailBones avatar Aug 10 '22 16:08 SnailBones