mapbox-directions-swift icon indicating copy to clipboard operation
mapbox-directions-swift copied to clipboard

Matrix API Integration

Open jill-cardamon opened this issue 3 years ago • 2 comments

Fixes #419.

This PR adds a Matrix object to access the Matrix API. Integration is similar to Directions and Isochrones. Needs to be rebased on top of main.

jill-cardamon avatar Nov 08 '21 17:11 jill-cardamon

@jill-cardamon, it'd be good to update this PR as it's pretty outdated.

MaximAlien avatar Feb 07 '22 18:02 MaximAlien

@1ec5, could you please take a look when you have time?

MaximAlien avatar Apr 04 '22 17:04 MaximAlien

Codecov Report

Merging #626 (9d50ad7) into main (bb9fe98) will decrease coverage by 0.95%. The diff coverage is 75.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   85.30%   84.34%   -0.96%     
==========================================
  Files          52       57       +5     
  Lines        4545     4854     +309     
==========================================
+ Hits         3877     4094     +217     
- Misses        668      760      +92     
Impacted Files Coverage Δ
Sources/MapboxDirections/AttributeOptions.swift 90.27% <ø> (ø)
Sources/MapboxDirections/MatrixOptions.swift 65.57% <65.57%> (ø)
Sources/MapboxDirections/MatrixResponse.swift 71.42% <71.42%> (ø)
Sources/MapboxDirections/MatrixError.swift 72.22% <72.22%> (ø)
Sources/MapboxDirections/Matrix.swift 74.73% <74.73%> (ø)
...rces/MapboxDirections/Extensions/URL+Request.swift 95.83% <95.83%> (ø)
Sources/MapboxDirections/Directions.swift 74.09% <100.00%> (-3.54%) :arrow_down:
Sources/MapboxDirections/Isochrones.swift 77.64% <100.00%> (ø)

codecov-commenter avatar Dec 15 '22 13:12 codecov-commenter

Detected breaking changes are not related to current PR:

  💔 API breakage: enumelement VisualInstruction.Component.guidanceView has declared type change from (MapboxDirections.VisualInstruction.Component.Type) -> (MapboxDirections.GuidanceViewImageRepresentation, MapboxDirections.VisualInstruction.Component.TextRepresentation) -> MapboxDirections.VisualInstruction.Component to (MapboxDirections.VisualInstruction.Component.Type) -> (MapboxDirections.GuidanceViewImageRepresentation, MapboxDirections.VisualInstruction.Component.TextRepresentation, MapboxDirections.VisualInstruction.Component.GuidanceViewKind?) -> MapboxDirections.VisualInstruction.Component

Udumft avatar Dec 21 '22 08:12 Udumft

Detected breaking changes are not related to current PR:

  💔 API breakage: enumelement VisualInstruction.Component.guidanceView has declared type change from (MapboxDirections.VisualInstruction.Component.Type) -> (MapboxDirections.GuidanceViewImageRepresentation, MapboxDirections.VisualInstruction.Component.TextRepresentation) -> MapboxDirections.VisualInstruction.Component to (MapboxDirections.VisualInstruction.Component.Type) -> (MapboxDirections.GuidanceViewImageRepresentation, MapboxDirections.VisualInstruction.Component.TextRepresentation, MapboxDirections.VisualInstruction.Component.GuidanceViewKind?) -> MapboxDirections.VisualInstruction.Component

Even if breaking change isn't related, it shouldn't be in output after PR is merged. https://github.com/mapbox/mapbox-directions-swift/tree/main/swift-package-baseline#the-procedure-of-accepting-breaking-changes describes what to do to accept a breaking change.

S2Ler avatar Jan 16 '23 03:01 S2Ler