weektodo icon indicating copy to clipboard operation
weektodo copied to clipboard

[Bug] Incorrect timezone

Open sudo-saif opened this issue 2 years ago • 12 comments

Title: Incorrect timezone

Description: Currently in Egypt, the time shifted to the day light saving timezone, i.e from 2+ GMT to 3+ GMT, but for some reason, the app is stuck at 2+ GMT When I set an alarm to 4 PM for example, it shows the alarm notification at 5 PM at my laptop's time.

Solution: I guess it follows the timezone set by some source on the internet, it should follow my local time on my machine instead.

sudo-saif avatar May 15 '23 14:05 sudo-saif

Thanks for reporting this, @SaifEl-Deen . In theory the application should be taking the local time, I'm going to check this by changing my local time and trying to replicate the error.

manuelernestog avatar May 28 '23 18:05 manuelernestog

It's looks like this is a bug from electron. This one is similar -> https://github.com/electron/electron/issues/20998

image

I'll open an issue in Electron repository :ok_hand:

Until that, this will keep locked.

manuelernestog avatar May 30 '23 18:05 manuelernestog

This is the Electron related issue https://github.com/electron/electron/issues/38496

manuelernestog avatar May 30 '23 18:05 manuelernestog

@SaifEl-Deen The electron team is trying to reproduce the bug, but they haven't been able to do it on Windows. Just so I can give them more information. What operating system are you using?

I'm on Ubuntu 22.04 and I can reproduce it.

manuelernestog avatar May 31 '23 13:05 manuelernestog

@manuelernestog

On windows 10

  1. Set timezone to Cairo +2 GMT
  2. Manually set the time so that it's +1 hour (i.e as if your timezone was +3 GMT but keep your timezone at +2 GMT)

sudo-saif avatar May 31 '23 13:05 sudo-saif

Thanks @SaifEl-Deen I'll let them know :+1:

manuelernestog avatar May 31 '23 14:05 manuelernestog

@SaifEl-Deen

  1. Manually set the time so that it's +1 hour (i.e as if your timezone was +3 GMT but keep your timezone at +2 GMT)

I'm not sure what you mean by this? Wouldn't this be the problem of the time lag?

manuelernestog avatar May 31 '23 14:05 manuelernestog

@manuelernestog Daylight saving time started a month ago in Egypt where time would be +3 GMT (ex. 4 PM became 5 PM) instead of +2 GMT, but windows doesn't recognize it and sets the time to +2 GMT, so, I have to turn off the automatic time setting ans set the time to be matching with +3 GMT.

sudo-saif avatar May 31 '23 15:05 sudo-saif

@SaifEl-Deen I see. I'm not sure if the guy from Electron maybe have to do something different here is the link with the discussion for if you want to add something there https://github.com/electron/electron/issues/38496#issuecomment-1570391412

manuelernestog avatar May 31 '23 15:05 manuelernestog

@SaifEl-Deen sorry again. Can u help me with this. It's looks like he is having problems to replicate the error.

image

manuelernestog avatar May 31 '23 17:05 manuelernestog

@manuelernestog It's okay, I'm glad you're caring to solve this problem. I replied to the main post there.

sudo-saif avatar May 31 '23 20:05 sudo-saif

Thanks @SaifEl-Deen Excellent!

manuelernestog avatar May 31 '23 21:05 manuelernestog