libaums icon indicating copy to clipboard operation
libaums copied to clipboard

Published 20 hours ago • verified publisher icon magnusja

Support for FAT 16 file systems

Open gopai opened this issue 6 years ago • 1 comments

We've added classes and tests cases for a FAT 16 file system

gopai avatar Mar 29 '19 15:03 gopai

Hey @gopai

I really really appreciate you support and your willingness to contribute! But tests are failing and it seems that you mostly copied code for FAT16, which is in generally a bad practice in software design.

FAT16 and FAT32 are actually VERY similar and only need distinction in code in some places! Have a look here please: https://github.com/waldheinz/fat32-lib

I am actually looking into integrating fat32-lib which supports FAT16. The only drawback it might have is performance AND fat32-lib is licensed under LGPL and not Apache like this library.

magnusja avatar Mar 29 '19 17:03 magnusja